WIP: Implement XShm screen capture #16

Draft

Benjamin wants to merge 39 commits from 5-implement-xshm-screen-capture into main

pull from: 5-implement-xshm-screen-capture

merge into: Benjamin:main

Benjamin:main

Benjamin:3-implement-windows-screen-capture

Benjamin:test-ci

Conversation 0 Commits 39 Files changed 12 +1592 -86

Benjamin commented 2026-07-01 17:33:08 +02:00

Owner

Copy link

Closes #5.

Closes #5.

Benjamin added the

feature

label 2026-07-01 17:33:08 +02:00

Benjamin self-assigned this 2026-07-01 17:33:08 +02:00

Benjamin added 25 commits 2026-07-01 17:33:08 +02:00

resolve merge conflict root cmakelists #3 69e1f4390e

lib: implement display capture with BitBlt #3 68cd506400

lib: add bitdeph, name and primary_monitor to display enumaration #3 9e6d3ea018

lib: fix rebase conflicts with main #3 ... 3b4f34e29f

# Conflicts:
#	libgruppensprechen/test/test.ui
#	libgruppensprechen/test/testwin.cpp

lib: implement mutex for video capture frame buffer #3 ... 25535783ea

fix rebase conflicts with main

lib: abstracted video frame buffer/mutex to FrameBuffer with double buffer #3 ... 5ff5f884bd

refactored GDIDisplay and monitorEnumProc
moved buffer allocation from getSingleCapture to FrameBuffer

lib: testwin: rename buttons and fix missing callback function for CaptureConfig #3 52174f71bd

lib: video: change interface to use CaptureHandle instead of raw Capture pointers #3 061865e88f

WIP: lib: implement starting and stopping of gdi video capture #3 67161f6576

WIP: lib: fix warnings except unused #3 bfac757289

lib: fix display capture switching #3 74714cc4d2

lib: testwin: synchronize screen capture image by using qt signals #3 5d1ffdf1af

lib: test: add log level parsing #3 afdd254cc6

lib: fix all clang warnings #3 46d408065d

lib: testwin: add average fps display #3 704d42922c

lib: videoman: make capture pure virtual, add getters #3 4ff91db2e1

lib: video: alloc/dealloc of gdi objects in constructor/destructor of GDICapture #3 ... 230a0625a9

Also clean up VideoMan api

lib: video: add ability to capture regions instead of whole displays only #3 26e1cb84c5

lib: video: make Framebuffer a template #3 b6c2d57469

lib: video: add error handling #3 6d46feed29

lib: GDIVideoMan: fix msvc build failure #3 ... 2796ae49d7

Also fix some msvc warnings

lib: video: more cleanup for function params and member names #3 cb2c44b26d

lib: video: add CaptureInfo object to keep the user from having to access dangling pointers #3 4728014f61

lib: video: fix id not being set for GDICapture #3 bffc8c3a11

lib: add video namespace and fix boost not found in cmake #3 ec57987310

Benjamin added 1 commit 2026-07-01 17:38:43 +02:00

lib: add empty XShmVideoMan stub and platform dependent compilation #5 9cdab41d71

Benjamin added 1 commit 2026-07-01 22:10:36 +02:00

lib: video: implement xrandr monitor enumeration #5 ace0b353d8

Benjamin added 1 commit 2026-07-01 22:18:53 +02:00

lib: fix bug to not use invalid memory in xrandr display enumeration #5 ... 174465f2a6

Also install pkgconf on arch ci

Benjamin added 1 commit 2026-07-01 22:23:44 +02:00

ci: remove ninja status env var for msvc #5 384c5a6677

Benjamin force-pushed 5-implement-xshm-screen-capture from 384c5a6677 to f15c1e41dd 2026-07-05 22:21:19 +02:00 Compare

Benjamin force-pushed 5-implement-xshm-screen-capture from f15c1e41dd to 4346ac4403 2026-07-06 17:56:20 +02:00 Compare

Benjamin force-pushed 5-implement-xshm-screen-capture from 4346ac4403 to 998d155fa0 2026-07-06 18:49:45 +02:00 Compare

Benjamin added 1 commit 2026-07-06 18:59:09 +02:00

lib: video: implement xcb shared memory buffer #5 f8ddead864

Benjamin added 2 commits 2026-07-06 20:36:44 +02:00

lib: testwin: discard video frames when qt is not done rendering the last one #5 ... cf73590f20

This caused memory consumption to grow uncontrollably, because xshm is
too performant :)

lib: video: implement xshm video capture #5 4e1c561bd3

Benjamin force-pushed 5-implement-xshm-screen-capture from 4e1c561bd3 to d4d13c53f4 2026-07-07 17:07:40 +02:00 Compare

Benjamin added 1 commit 2026-07-07 21:14:37 +02:00

lib: video: carry over some changes from XShmCapture to GDICapture #5 ... f0f1135656

Also yield thread and sleep when capture fails to avoid busy waiting

Benjamin added 1 commit 2026-07-07 21:41:24 +02:00

lib: video: add support for different pixmap formats to make gdi and xshm work #5 a9e5f47381

Benjamin force-pushed 5-implement-xshm-screen-capture from a9e5f47381 to ca0c811b0d 2026-07-08 20:24:07 +02:00 Compare

All checks were successful

Hide all checks

ci / build (push) Successful in 2m49s

Required

Details

ci-windows / build-msvc (push) Successful in 5m59s

Required

Details

ci-windows / build-mingw (push) Successful in 7m27s

Required

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 5-implement-xshm-screen-capture:5-implement-xshm-screen-capture

git switch 5-implement-xshm-screen-capture

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

feature

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

feature

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

Benjamin

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Benjamin/gruppensprechen!16

No description provided.